message_bus / message_bus_service · 提交

转到一个项目

作者 王勇
提交 5e9c81de47fadb2e29407de9e70ba4ff661f1e90 1 个父辈 41e6cbc1

简单优化Controller层代码

内嵌 并排对比
正在显示 2 个修改的文件 包含 35 行增加 和 71 行删除
@@ -54,7 +54,7 @@ public class UserMessageBindingController { @@ -54,7 +54,7 @@ public class UserMessageBindingController {
54 * @return 列表 {@link ResultJson} 54 * @return 列表 {@link ResultJson}
55 */ 55 */
56 @GetMapping("/list") 56 @GetMapping("/list")
57 - public ResultJson<PageInfo> selectUserMessageBindingList( 57 + public ResultJson selectUserMessageBindingList(
58 @RequestParam(value = "username", required = false) String username, 58 @RequestParam(value = "username", required = false) String username,
59 @RequestParam(value = "serverName", required = false) String serverName, 59 @RequestParam(value = "serverName", required = false) String serverName,
60 @RequestParam(value = "virtualHostName", required = false) String virtualHostName, 60 @RequestParam(value = "virtualHostName", required = false) String virtualHostName,
@@ -64,35 +64,13 @@ public class UserMessageBindingController { @@ -64,35 +64,13 @@ public class UserMessageBindingController {
64 @RequestParam(value = "subscriber", required = false) String subscriber, 64 @RequestParam(value = "subscriber", required = false) String subscriber,
65 @RequestParam(value = "pageNum", defaultValue = "1") Integer pageNum, 65 @RequestParam(value = "pageNum", defaultValue = "1") Integer pageNum,
66 @RequestParam(value = "pageSize", defaultValue = "10") Integer pageSize) { 66 @RequestParam(value = "pageSize", defaultValue = "10") Integer pageSize) {
67 -  
68 - ResultJson<PageInfo> result = new ResultJson<>();  
69 -  
70 - UserMessageBinding userMessageBinding = new UserMessageBinding();  
71 - // 获取参数，所属用户登陆名称  
72 - userMessageBinding.setUsername(username);  
73 - // 获取参数，所属服务器名称  
74 - userMessageBinding.setServerName(serverName);  
75 - // 获取参数，所属虚拟主机名称  
76 - userMessageBinding.setVirtualHostName(virtualHostName);  
77 - // 获取参数，所属交换机名称  
78 - userMessageBinding.setExchangeName(exchangeName);  
79 - // 获取参数，所属队列名称  
80 - userMessageBinding.setQueueName(queueName);  
81 - // 获取参数，所属路由键名称  
82 - userMessageBinding.setRoutingKeyName(routingKeyName);  
83 - // 获取参数，订阅者  
84 - userMessageBinding.setSubscriber(subscriber); 67 + // 获取查询参数
  68 + UserMessageBinding userMessageBinding = new UserMessageBinding(username, serverName, virtualHostName, exchangeName, queueName, routingKeyName, subscriber);
85 // 分页查询 69 // 分页查询
86 PageInfo pageInfo = userMessageBindingService.selectUserMessageBindingList(userMessageBinding, pageNum, pageSize); 70 PageInfo pageInfo = userMessageBindingService.selectUserMessageBindingList(userMessageBinding, pageNum, pageSize);
87 - if (pageInfo.getTotal() > 0) {  
88 - result.setCode("200");  
89 - result.setData(pageInfo);  
90 - result.setMsg("查询-账户消息绑定配置列表,成功!");  
91 - } else {  
92 - result.setCode("500");  
93 - result.setMsg("查询-账户消息绑定配置列表,失败!");  
94 - }  
95 - return result; 71 + return pageInfo.getTotal() > 0
  72 + ? new ResultJson<>("200", "查询-账户消息绑定配置列表,成功!", pageInfo)
  73 + : new ResultJson<>("500", "查询-账户消息绑定配置列表,失败!");
96 } 74 }
97 75
98 /** 76 /**
@@ -103,16 +81,10 @@ public class UserMessageBindingController { @@ -103,16 +81,10 @@ public class UserMessageBindingController {
103 */ 81 */
104 @DeleteMapping("/delete") 82 @DeleteMapping("/delete")
105 public ResultJson deleteUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding) { 83 public ResultJson deleteUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding) {
106 - ResultJson result = new ResultJson<>();  
107 - int num = userMessageBindingService.deleteByPrimaryKey(userMessageBinding.getId());  
108 - if (num > 0) {  
109 - result.setCode("200");  
110 - result.setMsg("删除-账户消息配置信息，成功");  
111 - } else {  
112 - result.setCode("500");  
113 - result.setMsg("删除-账户消息配置信息，失败");  
114 - }  
115 - return result; 84 + // 执行删除方法
  85 + return userMessageBindingService.deleteByPrimaryKey(userMessageBinding.getId()) > 0
  86 + ? new ResultJson<>("200", "删除-账户消息配置信息，成功")
  87 + : new ResultJson<>("500", "删除-账户消息配置信息，失败");
116 } 88 }
117 89
118 /** 90 /**
@@ -123,16 +95,10 @@ public class UserMessageBindingController { @@ -123,16 +95,10 @@ public class UserMessageBindingController {
123 */ 95 */
124 @GetMapping("/batchRemove") 96 @GetMapping("/batchRemove")
125 public ResultJson batchRemoveUserMessageBinding(String ids) { 97 public ResultJson batchRemoveUserMessageBinding(String ids) {
126 - ResultJson result = new ResultJson<>();  
127 - int num = userMessageBindingService.deleteByPrimaryKey(ids);  
128 - if (num > 0) {  
129 - result.setCode("200");  
130 - result.setMsg("批量删除-账户消息配置-信息,成功!");  
131 - } else {  
132 - result.setCode("500");  
133 - result.setMsg("批量删除-账户消息配置-信息,失败!");  
134 - }  
135 - return result; 98 + // 执行批量删除
  99 + return userMessageBindingService.deleteByPrimaryKey(ids) > 0
  100 + ? new ResultJson<>("200", "批量删除-账户消息配置信息，成功")
  101 + : new ResultJson<>("500", "批量删除-账户消息配置信息，失败");
136 } 102 }
137 103
138 /** 104 /**
@@ -143,16 +109,10 @@ public class UserMessageBindingController { @@ -143,16 +109,10 @@ public class UserMessageBindingController {
143 */ 109 */
144 @PutMapping("/update") 110 @PutMapping("/update")
145 public ResultJson updateUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding) { 111 public ResultJson updateUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding) {
146 - ResultJson result = new ResultJson<>();  
147 - int num = userMessageBindingService.updateByPrimaryKeySelective(umb_fillName(userMessageBinding));  
148 - if (num > 0) {  
149 - result.setCode("200");  
150 - result.setMsg("编辑-账户消息配置-信息，成功");  
151 - } else {  
152 - result.setCode("500");  
153 - result.setMsg("编辑-账户消息配置-信息，失败");  
154 - }  
155 - return result; 112 + // 执行编辑
  113 + return userMessageBindingService.updateByPrimaryKeySelective(umb_fillName(userMessageBinding)) > 0
  114 + ? new ResultJson<>("200", "编辑-账户消息配置-信息，成功")
  115 + : new ResultJson<>("500", "编辑-账户消息配置-信息，失败");
156 } 116 }
157 117
158 /** 118 /**
@@ -163,18 +123,12 @@ public class UserMessageBindingController { @@ -163,18 +123,12 @@ public class UserMessageBindingController {
163 */ 123 */
164 @PostMapping("/insert") 124 @PostMapping("/insert")
165 public ResultJson insertUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding) { 125 public ResultJson insertUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding) {
166 - ResultJson result = new ResultJson<>();  
167 // 设置id 126 // 设置id
168 userMessageBinding.setId(IdUtils.generateId()); 127 userMessageBinding.setId(IdUtils.generateId());
169 - int num = userMessageBindingService.insertSelective(umb_fillName(userMessageBinding));  
170 - if (num > 0) {  
171 - result.setCode("200");  
172 - result.setMsg("添加-账户消息配置-信息，成功");  
173 - } else {  
174 - result.setCode("500");  
175 - result.setMsg("添加-账户消息配置-信息，失败");  
176 - }  
177 - return result; 128 + // 执行新增
  129 + return userMessageBindingService.insertSelective(umb_fillName(userMessageBinding)) > 0
  130 + ? new ResultJson<>("200", "添加-账户消息配置-信息，成功")
  131 + : new ResultJson<>("500", "添加-账户消息配置-信息，失败");
178 } 132 }
179 133
180 /** 134 /**
1 package com.sunyo.wlpt.message.bus.service.domain; 1 package com.sunyo.wlpt.message.bus.service.domain;
2 2
3 -import java.io.Serializable;  
4 -import java.util.Date;  
5 -  
6 import lombok.AllArgsConstructor; 3 import lombok.AllArgsConstructor;
7 import lombok.Data; 4 import lombok.Data;
8 import lombok.NoArgsConstructor; 5 import lombok.NoArgsConstructor;
9 6
  7 +import java.io.Serializable;
  8 +import java.util.Date;
  9 +
10 /** 10 /**
11 * @author 子诚 11 * @author 子诚
12 * Description：账户信息绑定配置表 12 * Description：账户信息绑定配置表
@@ -103,4 +103,14 @@ public class UserMessageBinding implements Serializable { @@ -103,4 +103,14 @@ public class UserMessageBinding implements Serializable {
103 * 修改时间 103 * 修改时间
104 */ 104 */
105 private Date gmtModified; 105 private Date gmtModified;
  106 +
  107 + public UserMessageBinding(String username, String serverName, String virtualHostName, String exchangeName, String queueName, String routingKeyName, String subscriber) {
  108 + this.username = username;
  109 + this.serverName = serverName;
  110 + this.virtualHostName = virtualHostName;
  111 + this.exchangeName = exchangeName;
  112 + this.queueName = queueName;
  113 + this.routingKeyName = routingKeyName;
  114 + this.subscriber = subscriber;
  115 + }
106 } 116 }