作者 王勇

简单优化Controller层代码

... ... @@ -2,10 +2,9 @@ package com.sunyo.wlpt.message.bus.service.controller;
import com.github.pagehelper.PageInfo;
import com.sunyo.wlpt.message.bus.service.domain.*;
import com.sunyo.wlpt.message.bus.service.domain.UserMessageBinding;
import com.sunyo.wlpt.message.bus.service.response.ResultJson;
import com.sunyo.wlpt.message.bus.service.service.*;
import com.sunyo.wlpt.message.bus.service.utils.IdUtils;
import com.sunyo.wlpt.message.bus.service.service.UserMessageBindingService;
import org.springframework.web.bind.annotation.*;
import javax.annotation.Resource;
... ... @@ -22,21 +21,6 @@ import javax.annotation.Resource;
public class UserMessageBindingController {
@Resource
private BusServerService busServerService;
@Resource
private VirtualHostService virtualHostService;
@Resource
private BusExchangeService busExchangeService;
@Resource
private BusQueueService busQueueService;
@Resource
private RoutingKeyService routingKeyService;
@Resource
private UserMessageBindingService userMessageBindingService;
/**
... ... @@ -63,7 +47,8 @@ public class UserMessageBindingController {
@RequestParam(value = "routingKeyName", required = false) String routingKeyName,
@RequestParam(value = "subscriber", required = false) String subscriber,
@RequestParam(value = "pageNum", defaultValue = "1") Integer pageNum,
@RequestParam(value = "pageSize", defaultValue = "10") Integer pageSize) {
@RequestParam(value = "pageSize", defaultValue = "10") Integer pageSize)
{
// 获取查询参数
UserMessageBinding userMessageBinding = UserMessageBinding.builder()
.username(username)
... ... @@ -88,7 +73,8 @@ public class UserMessageBindingController {
* @return {@link ResultJson}
*/
@DeleteMapping("/delete")
public ResultJson deleteUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding) {
public ResultJson deleteUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding)
{
// 执行删除方法
return userMessageBindingService.deleteByPrimaryKey(userMessageBinding.getId()) > 0
? new ResultJson<>("200", "删除-账户消息配置信息,成功")
... ... @@ -102,7 +88,8 @@ public class UserMessageBindingController {
* @return {@link ResultJson}
*/
@GetMapping("/batchRemove")
public ResultJson batchRemoveUserMessageBinding(String ids) {
public ResultJson batchRemoveUserMessageBinding(String ids)
{
// 执行批量删除
return userMessageBindingService.deleteByPrimaryKey(ids) > 0
? new ResultJson<>("200", "批量删除-账户消息配置信息,成功")
... ... @@ -116,9 +103,10 @@ public class UserMessageBindingController {
* @return {@link ResultJson}
*/
@PutMapping("/update")
public ResultJson updateUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding) {
public ResultJson updateUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding)
{
// 执行编辑
return userMessageBindingService.updateByPrimaryKeySelective(umb_fillName(userMessageBinding)) > 0
return userMessageBindingService.updateByPrimaryKeySelective(userMessageBinding) > 0
? new ResultJson<>("200", "编辑-账户消息配置-信息,成功")
: new ResultJson<>("500", "编辑-账户消息配置-信息,失败");
}
... ... @@ -130,40 +118,11 @@ public class UserMessageBindingController {
* @return {@link ResultJson}
*/
@PostMapping("/insert")
public ResultJson insertUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding) {
// 设置id
userMessageBinding.setId(IdUtils.generateId());
public ResultJson insertUserMessageBinding(@RequestBody UserMessageBinding userMessageBinding)
{
// 执行新增
return userMessageBindingService.insertSelective(umb_fillName(userMessageBinding)) > 0
return userMessageBindingService.insertSelective(userMessageBinding) > 0
? new ResultJson<>("200", "添加-账户消息配置-信息,成功")
: new ResultJson<>("500", "添加-账户消息配置-信息,失败");
}
/**
* 编辑 or 新增方法,根绝前端传递来的id值,来填充对应的name
* 服务器id,虚拟主机id,交换机id,队列id,路由键id
*/
public UserMessageBinding umb_fillName(UserMessageBinding userMessageBinding) {
// 填充,服务器名称
BusServer busServer = busServerService.selectByPrimaryKey(userMessageBinding.getServerId());
userMessageBinding.setServerName(busServer.getServerName());
// 填充,虚拟主机名称
VirtualHost virtualHost = virtualHostService.selectByPrimaryKey(userMessageBinding.getVirtualHostId());
userMessageBinding.setVirtualHostName(virtualHost.getVirtualHostName());
// 填充,交换机名称
BusExchange busExchange = busExchangeService.selectByPrimaryKey(userMessageBinding.getExchangeId());
userMessageBinding.setExchangeName(busExchange.getExchangeName());
// 填充,队列名称
BusQueue busQueue = busQueueService.selectByPrimaryKey(userMessageBinding.getQueueId());
userMessageBinding.setQueueName(busQueue.getQueueName());
// 填充,路由键名称
RoutingKey routingKey = routingKeyService.selectByPrimaryKey(userMessageBinding.getRoutingKeyId());
userMessageBinding.setRoutingKeyName(routingKey.getRoutingKeyName());
return userMessageBinding;
}
}
... ...